Change property condition check to a function, add nestng support. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM with passing all the extra NOT tests |
|
Thanks guys! |
* Add macros for "servicedata" and "manufacturerdata" * Add support for nested arrays in property conditions. * Allow for using NOT property conditions at any position. This will allow for the NOT condition to be placed in any position within a property condition, allowing for greater efficiency. * Minor code cleanup
h2zero
force-pushed
the
check-prop-cond-func
branch
from
021c14b to
d8500b4
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Moves the property condition check to a new function. This allows for the use of nested arrays as the function can be called recursively.
Example (json array nesting):
TODO: docs
Checklist: